Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove required multi-cluster allocation policy fields that are not required #1100

Merged
merged 3 commits into from
Oct 14, 2019
Merged

Remove required multi-cluster allocation policy fields that are not required #1100

merged 3 commits into from
Oct 14, 2019

Conversation

pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Oct 4, 2019

clusterName and secretName are not required fields for local cluster allocation policy and they should be removed from required.
The feature is in alpha version.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 7045b2a0-7898-4130-8bad-4d9c026bfce0

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1100/head:pr_1100 && git checkout pr_1100
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-b37894b

@google-oss-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pooneh-m, roberthbailey
To complete the pull request process, please assign
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@roberthbailey
Copy link
Member

/lgtm

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 03833498-df29-4d05-8ad6-9c2c53689898

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@roberthbailey
Copy link
Member

Failed test:

--- FAIL: TestMultiClusterAllocationOnLocalCluster (0.01s)
    --- FAIL: TestMultiClusterAllocationOnLocalCluster/Distributed (38.11s)
        gameserverallocation_test.go:80: Namespace gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06 is created
        gameserverallocation_test.go:80: ServiceAccount gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06/agones-sdk is created
        gameserverallocation_test.go:80: RoleBinding gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06/agones-sdk-access is created
        gameserverallocation_test.go:182: 
            	Error Trace:	gameserverallocation_test.go:182
            	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"an error on the server (\"no multi-cluster allocation policy is specified\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)", Reason:"InternalError", Details:(*v1.StatusDetails)(0xc0006c11a0), Code:500}}
            	Test:       	TestMultiClusterAllocationOnLocalCluster/Distributed
        gameserverallocation_test.go:185: Namespace gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06 is deleted

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: b040371f-f485-4798-a839-44b88a73fe68

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1100/head:pr_1100 && git checkout pr_1100
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-7bc67b6

@pooneh-m
Copy link
Contributor Author

Failed test:

--- FAIL: TestMultiClusterAllocationOnLocalCluster (0.01s)
    --- FAIL: TestMultiClusterAllocationOnLocalCluster/Distributed (38.11s)
        gameserverallocation_test.go:80: Namespace gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06 is created
        gameserverallocation_test.go:80: ServiceAccount gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06/agones-sdk is created
        gameserverallocation_test.go:80: RoleBinding gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06/agones-sdk-access is created
        gameserverallocation_test.go:182: 
            	Error Trace:	gameserverallocation_test.go:182
            	Error:      	Expected nil, but got: &errors.StatusError{ErrStatus:v1.Status{TypeMeta:v1.TypeMeta{Kind:"", APIVersion:""}, ListMeta:v1.ListMeta{SelfLink:"", ResourceVersion:"", Continue:""}, Status:"Failure", Message:"an error on the server (\"no multi-cluster allocation policy is specified\") has prevented the request from succeeding (post gameserverallocations.allocation.agones.dev)", Reason:"InternalError", Details:(*v1.StatusDetails)(0xc0006c11a0), Code:500}}
            	Test:       	TestMultiClusterAllocationOnLocalCluster/Distributed
        gameserverallocation_test.go:185: Namespace gsa-multicluster-local-d315759e-eeb0-11e9-8b30-0242c0a80a06 is deleted

It was a flake. The change in this PR is unrelated. However, I think what happened was there was a race condition that creating the GameServerAllocationPolicy happened after the allocation request though the request to Kubernetes to create the CR succeeded.

@google-oss-robot
Copy link

New changes are detected. LGTM label has been removed.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 2ab3e7c1-bd89-4f7a-b411-8f330acdc54a

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/1100/head:pr_1100 && git checkout pr_1100
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=1.1.0-58de51f

@roberthbailey roberthbailey merged commit fe39af7 into googleforgames:master Oct 14, 2019
@markmandel markmandel added this to the 1.1.0 milestone Oct 22, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Oct 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey roberthbailey approved these changes

Assignees

@roberthbailey roberthbailey

Labels
kind/cleanup Refactoring code, fixing up documentation, etc size/XS
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.
5 participants
@pooneh-m @agones-bot @google-oss-robot @roberthbailey @markmandel